install: Some cleanups around root_path #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I personally find mutations harder to follow as a code reader/debugger, even if they're sometimes "simpler" (mostly in terms of LoC) and more performant, but it's all very subjective |
Closed
omertuc
approved these changes
Nov 19, 2024
omertuc
requested changes
Nov 19, 2024
cgwalters
force-pushed
the
minor-install-root-path
branch
from
e8f5fd1 to
0927a05
Compare
The extra cloning we were doing here looked odd to me. I think this ends up being cleaner make the toplevel variable mutable and replace it only in the circumstance we detect an ostree deployment. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
minor-install-root-path
branch
from
0927a05 to
784b31c
Compare
omertuc
approved these changes
Nov 19, 2024
Agreed that the mutation can be confusing, but I think in this case it is clearer than creating a shadowed copy of the same value. However I have some other followups here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra cloning we were doing here looked odd to me. I think this ends up being cleaner make the toplevel variable mutable and replace it only in the circumstance we detect an ostree deployment.