This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
godep: bump the version of rkt to v1.2.0 #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build broke |
cgonyeo
force-pushed
the
bump-appc
branch
6 times, most recently
from
c23dc96 to
a634e58
Compare
|
Fixed the build. Apparently I need |
|
Eurgh. Instead, set GOPATH: https://github.com/appc/spec/pull/578/files#diff-b0da275520918e23dd615e2a747528f1L13 |
|
Also if you're going to unrewrite paths too (which I think is probably a good idea at this stage), please add something to the commit message to that effect (or split it into two commits) |
…ipts Wanted to bump appc to 0.7.4, which is the result of bumping rkt to 1.2.0. Also unrewrote imports, and tweaked the build and test scripts appropriately. The build and test scripts were also modified to work when called from any directory, instead of only working when the current directory was the acbuild repo.
|
Tweaked the commit message, and decided to mess with the build/test scripts while I'm here. |
|
Can't actually review the important changes, thanks github :-( |
|
The big change in the build/test scripts is this: |
|
if it works, ship it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until a consensus is reached on moving to glide, I'd like to bump the appc version (which required bumping the rkt version) used by acbuild. This allows for apps with an empty exec statement.