This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
run: --debug flag caused a panic with the Uncompress progress bar #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent refactor resulted in the registry being correctly passed the debug value, which exposed an issue with an additional progress bar that was being drawn when uncompressing a dependency. The panic was a combination of the logic drawing the bar passing the ioprogress library a number that was too small for the total size, and the ioprogress library not having a patch to be able to handle incorrect numbers. This commit removes the uncompressing bar, and updates the ioprogress library. Fixes containers#56
|
LGTM |
cgonyeo
pushed a commit
that referenced
this pull request
Oct 23, 2015
run: --debug flag caused a panic with the Uncompress progress bar
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent refactor resulted in the registry being correctly passed the
debug value, which exposed an issue with an additional progress bar that
was being drawn when uncompressing a dependency.
The panic was a combination of the logic drawing the bar passing the
ioprogress library a number that was too small for the total size, and
the ioprogress library not having a patch to be able to handle incorrect
numbers.
This commit removes the uncompressing bar, and updates the ioprogress
library.
Fixes #56