Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildah pull with long tag needs to tab output appropriately like Podman does #1239

Closed
TomSweeneyRedHat opened this issue Dec 14, 2018 · 7 comments · Fixed by #1398
Closed

Comments

@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Dec 14, 2018

Description

As noted by @ypu here: https://jira.coreos.com/browse/RUN-24, if you pull an image like:

buildah pull alpine@sha256:1072e499f3f655a032e88542330cf75b02e7bdf673278f701d7ba61629ee3ebe

The image tag is huge. The image appears to be usable though.

Steps to reproduce the issue:
See description.

Describe the results you received:

# buildah images
IMAGE NAME                                               IMAGE TAG            IMAGE ID             CREATED AT             SIZE
docker.io/library/alpine@sha256                          1072e499f3f655a032e88542330cf75b02e7bdf673278f701d7ba61629ee3ebe 7328f6f8b418         Jun 27, 2017 14:42     4.22 MB

Describe the results you expected:

See output of podman images

Output of buildah version:

# buildah version
Version:         1.6-dev
Go Version:      go1.10.4
Image Spec:      1.0.0
Runtime Spec:    1.0.0
CNI Spec:        0.4.0
libcni Version:  v0.7.0-alpha1
Git Commit:      de7f480a
Built:           Fri Dec 14 06:53:58 2018
OS/Arch:         linux/amd64

Output of cat /etc/*release:

# cat /etc/*release
Fedora release 28 (Twenty Eight)
NAME=Fedora
VERSION="28 (Server Edition)"
ID=fedora
VERSION_ID=28
PLATFORM_ID="platform:f28"
PRETTY_NAME="Fedora 28 (Server Edition)"
ANSI_COLOR="0;34"
CPE_NAME="cpe:/o:fedoraproject:fedora:28"
HOME_URL="https://fedoraproject.org/"
SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=28
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=28
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Server Edition"
VARIANT_ID=server
Fedora release 28 (Twenty Eight)
Fedora release 28 (Twenty Eight)

Output of uname -a:

# uname -a
Linux localhost.localdomain 4.18.17-200.fc28.x86_64 #1 SMP Mon Nov 5 18:04:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

@vrothberg
Copy link
Member

vrothberg commented Dec 17, 2018

@TomSweeneyRedHat, which version of Podman are you using? 0.12.1.1 and latest master of Podman don't transform it to none but they correctly adjust the width of the IMAGE ID column. I was checking it as printing none seems a bit unfriendly to the user as it would leave the impression that the image really has no tag.

@TomSweeneyRedHat
Copy link
Member Author

Hmm, thought I was on master...

# podman version
Version:       0.12.2-dev
Go Version:    go1.10.4
Git Commit:    "94ee08109fd9179cba3d49a1d4c326810689d970-dirty"
Built:         Thu Dec 13 19:58:57 2018
OS/Arch:       linux/amd64

@TomSweeneyRedHat
Copy link
Member Author

Just double checked, you're right, Podman isn't replacing with <none> any more. It just adjusts the tabs:

# podman images
REPOSITORY                        TAG                                                                IMAGE ID       CREATED         SIZE
localhost/buildahimage            latest                                                             b1c773cce75f   45 hours ago    562 MB
docker.io/library/fedora          latest                                                             8c568f104326   5 weeks ago     275 MB
docker.io/library/alpine@sha256   1072e499f3f655a032e88542330cf75b02e7bdf673278f701d7ba61629ee3ebe   7328f6f8b418   17 months ago   4.22 MB

# buildah images
IMAGE NAME                                               IMAGE TAG            IMAGE ID             CREATED AT             SIZE
docker.io/library/fedora                                 latest               8c568f104326         Nov 6, 2018 19:23      275 MB
localhost/buildahimage                                   latest               b1c773cce75f         Dec 15, 2018 14:23     562 MB
docker.io/library/alpine@sha256                          1072e499f3f655a032e88542330cf75b02e7bdf673278f701d7ba61629ee3ebe 7328f6f8b418         Jun 27, 2017 14:42     4.22 MB

@TomSweeneyRedHat
Copy link
Member Author

So after looking further, let's change this to make the tabbing work as it does in Podman and leave the image id as is.

@vrothberg
Copy link
Member

Sounds good to me :)

@rhatdan
Copy link
Member

rhatdan commented Dec 17, 2018

While in there, can you also "s/IMAGE TAG/TAG" in the heading and fix the tabs to
podman images
and
buildah images
basically give the same output.

@TomSweeneyRedHat TomSweeneyRedHat changed the title Buildah pull with long tag needs to convert tag to <none> like Podman does Buildah pull with long tag needs to tab output appropriately like Podman does Dec 19, 2018
@rhatdan
Copy link
Member

rhatdan commented Mar 8, 2019

@TomSweeneyRedHat Any progress on this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants