Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug images use the template to print results #1398

Merged
merged 1 commit into from
Mar 12, 2019
Merged

fix bug images use the template to print results #1398

merged 1 commit into from
Mar 12, 2019

Conversation

QiWang19
Copy link
Contributor

@QiWang19 QiWang19 commented Mar 10, 2019 •
edited
Loading

Replace the hard code format with the template from podman. The format is ok with long imag tag or name.

fix #1239

$ sudo buildah images
REPOSITORY                    TAG                                                                IMAGE ID       CREATED        SIZE
<none>                        <none>                                                             bd2e2e2344cc   4 hours ago    83.3 MB
docker.io/library/node        alpine                                                             a13f3a3ed57f   46 hours ago   79.5 MB
localhost/app                 latest                                                             a13f3a3ed57f   46 hours ago   79.5 MB
localhost/hitheretherethere   1072e499f3f655a032e88542330cf75b02e7bdf673278f701d7ba61629ee3ebe   a13f3a3ed57f   46 hours ago   79.5 MB

$ sudo podman images
REPOSITORY                    TAG                                                                IMAGE ID       CREATED        SIZE
<none>                        <none>                                                             bd2e2e2344cc   5 hours ago    83.3 MB
docker.io/library/node        alpine                                                             a13f3a3ed57f   46 hours ago   79.5 MB
localhost/app                 latest                                                             a13f3a3ed57f   46 hours ago   79.5 MB
localhost/hitheretherethere   1072e499f3f655a032e88542330cf75b02e7bdf673278f701d7ba61629ee3ebe   a13f3a3ed57f   46 hours ago   79.5 MB

Signed-off-by: Qi Wang qiwan@redhat.com

@QiWang19 QiWang19 force-pushed the 1239 branch 4 times, most recently from 851947d to 38c7362 Compare March 10, 2019 16:26
@rhatdan
Copy link
Member

rhatdan commented Mar 11, 2019

We don't want to vendor anything in from libpod into buildah. If you want to share content between the two tools, then move the content to buildah and vendor it into libpod.

@QiWang19 QiWang19 force-pushed the 1239 branch 2 times, most recently from 1f76290 to dc009f5 Compare March 11, 2019 15:48
@QiWang19 QiWang19 mentioned this pull request Mar 11, 2019
Merged
@QiWang19 QiWang19 force-pushed the 1239 branch 4 times, most recently from 345ffc2 to d347de9 Compare March 11, 2019 19:51
@TomSweeneyRedHat
Copy link
Member

@QiWang19 you've some gitvalidate issues:

# Run gofmt on version 1.11 and higher
cmd/buildah/images.go:466:1:warning: outputUsingTemplate is unused (deadcode)
cmd/buildah/images.go:486:1:warning: outputUsingFormatString is unused (deadcode)

@QiWang19
fix bug images use the template to print results
a9f718b 
Signed-off-by: Qi Wang <qiwan@redhat.com>
@vrothberg
Copy link
Member

LGTM, let's get this merged soon as Podman is vendoring this PR's branch now instead of github.com/containers/buildah (see containers/podman#2609 (comment)). I am currently blocked on it.

@TomSweeneyRedHat
Copy link
Member

LGTM
I've added this one onto my list of wait for merge b4 vendoring Buildah into Podman.
@rhatdan can you take one more quick look at this?

@QiWang19
Copy link
Contributor Author

oh sorrry, forgot to add the do not merge tag for that PR.

@rhatdan
Copy link
Member

rhatdan commented Mar 12, 2019

@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit a9f718b has been approved by rhatdan

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit a9f718b with merge 7b221a6...

rh-atomic-bot pushed a commit that referenced this pull request Mar 12, 2019
@QiWang19 @rh-atomic-bot
fix bug images use the template to print results
7b221a6 
Signed-off-by: Qi Wang <qiwan@redhat.com>

Closes: #1398
Approved by: rhatdan
@rh-atomic-bot rh-atomic-bot mentioned this pull request Mar 12, 2019
Merged
@rhatdan
Copy link
Member

rhatdan commented Mar 12, 2019

@rh-atomic-bot retry

@rhatdan
Copy link
Member

rhatdan commented Mar 12, 2019

Homu is not responding. Going to force mere.

@rhatdan rhatdan merged commit 494ee56 into containers:master Mar 12, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
locked - please file new issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buildah pull with long tag needs to tab output appropriately like Podman does
5 participants
@QiWang19 @rhatdan @TomSweeneyRedHat @vrothberg @rh-atomic-bot