Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rootless: honor --net host #1395

Merged
merged 1 commit into from
Mar 12, 2019
Merged

rootless: honor --net host #1395

merged 1 commit into from
Mar 12, 2019

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Mar 8, 2019

when running in rootless mode, do not use slirp4netns if --net host is
specified.

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

@giuseppe giuseppe force-pushed the buildah-honor-net branch from 66ab54f to d12cd81 Compare March 8, 2019 14:14
@giuseppe giuseppe mentioned this pull request Mar 8, 2019
Merged
@rhatdan
Copy link
Member

rhatdan commented Mar 8, 2019

LGTM

TomSweeneyRedHat
TomSweeneyRedHat reviewed Mar 8, 2019
View reviewed changes
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
c'mon Travis move your blooming ....

imagebuildah/build.go
Stdout: b.out,
Stderr: b.err,
Quiet: b.quiet,
NamespaceOptions: b.namespaceOptions,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self, alphabetize these some day. @giuseppe don't do so today unless you've other things to fix in here.

@TomSweeneyRedHat
Copy link
Member

looks like a registry flake. @rhatdan can you rekick this as the bot loves to ignore me lately.

@rhatdan
Copy link
Member

rhatdan commented Mar 8, 2019

@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit d12cd81 has been approved by rhatdan

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit d12cd81 with merge 16e6ac2...

rh-atomic-bot pushed a commit that referenced this pull request Mar 8, 2019
@giuseppe @rh-atomic-bot
rootless: honor --net host
16e6ac2 
when running in rootless mode, do not use slirp4netns if --net host is
specified.

Closes: #1223

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

Closes: #1395
Approved by: rhatdan
@rh-atomic-bot
Copy link
Collaborator

💔 Test failed - status-travis

@TomSweeneyRedHat TomSweeneyRedHat mentioned this pull request Mar 8, 2019
Closed
@giuseppe
Copy link
Member Author

giuseppe commented Mar 9, 2019

@rh-atomic-bot retry

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit d12cd81 with merge a7be02d...

rh-atomic-bot pushed a commit that referenced this pull request Mar 9, 2019
@giuseppe @rh-atomic-bot
rootless: honor --net host
a7be02d 
when running in rootless mode, do not use slirp4netns if --net host is
specified.

Closes: #1223

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

Closes: #1395
Approved by: rhatdan
@rh-atomic-bot
Copy link
Collaborator

💔 Test failed - status-travis

@TomSweeneyRedHat
Copy link
Member

@giuseppe still looks to failing on test 77 with a flake it appears. I can get to the file it can't find from my pc, so I'm not quite sure what's going on there, very weird...

not ok 77 bud with preprocessor
# (in test file ./bud.bats, line 966)
#   `[ "$status" -eq 0 ]' failed
# Hello world!
# fetch http://dl-cdn.alpinelinux.org/alpine/v3.9/main/x86_64/APKINDEX.tar.gz
# ERROR: fetch http://dl-cdn.alpinelinux.org/alpine/v3.9/community/x86_64/APKINDEX.tar.gz
# http://dl-cdn.alpinelinux.org/alpine/v3.9/main: temporary error (try again later)
# WARNING: Ignoring APKINDEX.b89edf6e.tar.gz: No such file or directory
# ERROR: http://dl-cdn.alpinelinux.org/alpine/v3.9/community: temporary error (try again later)
# WARNING: Ignoring APKINDEX.737f7e01.tar.gz: No such file or directory
# 2 errors; 14 distinct packages available
# error building at step {Env:[PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin] Command:run Args:[apk update] Flags:[] Attrs:map[] Message:RUN apk update Original:RUN apk update}: error while running runtime: exit status 2
ok 78 bud with preprocessor error

@TomSweeneyRedHat
Copy link
Member

Maybe rebase and repush to start the build fresh?

@giuseppe giuseppe force-pushed the buildah-honor-net branch from d12cd81 to 7f7576a Compare March 9, 2019 20:51
giuseppe added a commit to giuseppe/libpod that referenced this pull request Mar 11, 2019
@giuseppe
build: honor --net
06e4441 
when --net is specified, pass it down to Buildah.

Depends on: containers/buildah#1395

Closes: containers#2572

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the buildah-honor-net branch 2 times, most recently from fa4f49e to 99bc2d1 Compare March 11, 2019 14:22
@rhatdan
Copy link
Member

rhatdan commented Mar 11, 2019

@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit 99bc2d1 has been approved by rhatdan

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit 99bc2d1 with merge 3419da6...

rh-atomic-bot pushed a commit that referenced this pull request Mar 11, 2019
@giuseppe @rh-atomic-bot
rootless: honor --net host
ab221a0 
when running in rootless mode, do not use slirp4netns if --net host is
specified.

Closes: #1223

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

Closes: #1395
Approved by: rhatdan
rh-atomic-bot pushed a commit that referenced this pull request Mar 11, 2019
@giuseppe @rh-atomic-bot
tests: choose a random mirror for Alpine Linux
3419da6 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

Closes: #1395
Approved by: rhatdan
@rh-atomic-bot
Copy link
Collaborator

💔 Test failed - status-travis

@giuseppe giuseppe force-pushed the buildah-honor-net branch from 99bc2d1 to ad9842e Compare March 11, 2019 21:27
@giuseppe giuseppe force-pushed the buildah-honor-net branch 3 times, most recently from 01499b4 to c144a76 Compare March 12, 2019 10:58
@giuseppe
rootless: honor --net host
042a249 
when running in rootless mode, do not use slirp4netns if --net host is
specified.

Closes: containers#1223

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the buildah-honor-net branch from c144a76 to 042a249 Compare March 12, 2019 12:48
@TomSweeneyRedHat
Copy link
Member

Once this and #1390 merge, I'll vendor Buildah in Podman. @mheon FYI

@giuseppe
Copy link
Member Author

finally Travis is happy!

@TomSweeneyRedHat
Copy link
Member

@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit 042a249 has been approved by TomSweeneyRedHat

@giuseppe
Copy link
Member Author

@rh-atomic-bot retry

@TomSweeneyRedHat
Copy link
Member

CI is just not letting its claws out of this PR....

@rhatdan
Copy link
Member

rhatdan commented Mar 12, 2019

@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

💡 This pull request was already approved, no need to approve it again.

@rh-atomic-bot
Copy link
Collaborator

📌 Commit 042a249 has been approved by rhatdan

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit 042a249 with merge cdbc567...

rh-atomic-bot pushed a commit that referenced this pull request Mar 12, 2019
@giuseppe @rh-atomic-bot
rootless: honor --net host
cdbc567 
when running in rootless mode, do not use slirp4netns if --net host is
specified.

Closes: #1223

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

Closes: #1395
Approved by: rhatdan
@rhatdan
Copy link
Member

rhatdan commented Mar 12, 2019

Homu is not working well today forcing merge.

@rhatdan rhatdan merged commit 3ba8822 into containers:master Mar 12, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

Assignees
No one assigned
Labels
locked - please file new issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@giuseppe @rhatdan @TomSweeneyRedHat @rh-atomic-bot