Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci:docs] Fix tutorial for rootless mode #2994

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Feb 10, 2021

Users have gotten confused when attempting the introduction turturial in
rootless mode. Explain that they have to buildah unshare before
mounting the image.

Fixes: #2833

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


@rhatdan rhatdan closed this Feb 10, 2021
@rhatdan rhatdan reopened this Feb 10, 2021
@rhatdan
Copy link
Member Author

rhatdan commented Feb 10, 2021

Oops wrong window.

Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit to clean, then LGTM

Users have gotten confused when attempting the introduction turturial in
rootless mode.  Explain that they have to `buildah unshare` before
mounting the image.

Fixes: containers#2833

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2e59c37 into containers:master Feb 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

running scratchmnt=$(buildah mount $newcontainer) in intro tutorial fails
4 participants