Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for image_parallel_copies in containers.conf #3176

Closed
wants to merge 1 commit into from

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Apr 22, 2021

Adding this feature to allow people with little band with to adjust the
ammount of threads pulling an image.

I don't have an easy way to test this other then manually.

[NO TESTS NEEDED]

Helps Fix: #2224

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Adding this feature to allow people with little band with to adjust the
ammount of threads pulling an image.

I don't have an easy way to test this other then manually.

[NO TESTS NEEDED]

Helps Fix: containers#2224

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member Author

rhatdan commented Apr 22, 2021

@vrothberg this might interfere with your big PR, so might have to wait.

@nalind
Copy link
Member

nalind commented Apr 22, 2021

LGTM. Have you been able to confirm this manually, at least, with images like registry.fedoraproject.org/f29/httpd or docker.io/library/swift, which have multiple layers?

@vrothberg
Copy link
Member

@vrothberg this might interfere with your big PR, so might have to wait.

Yes, please don't merge. We can handle all of that transparently in libimage, so I don't think we actually need a Buildah PR for it.

@rhatdan
Copy link
Member Author

rhatdan commented Apr 22, 2021

@nalind Yes I verified this works. @vrothberg ALready opened a PR and got it merged in containers/common.

@rhatdan rhatdan closed this Apr 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buildah failing to pull large docker images with error storing to blob file
4 participants