Scrub user and group names from layer diffs #4181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
kind/bug
When generating layer diffs or extracting container contents, scrub the user and group name fields in tar headers before saving them. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
scrub-usernames
branch
from
3075d6a to
da4647b
Compare
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When generating layer diffs or extracting container contents, scrub the user and group name fields in tar headers before saving them. By default, we were looking up the names of local users and groups, and if we found some that corresponded to contents of layers that we were saving, we stored those names along with the UID and GID information for items in layers.
How to verify it
New integration test!
Which issue(s) this PR fixes:
Fixes #4180.
Special notes for your reviewer:
Does this PR introduce a user-facing change?