stage_executor,cache-to: attempt to push cache only when cacheKey is valid
#4650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buildah's layer caching does not generates cache key or uses a layer from store if `RUN --mount` is used to make sure that always freshly mounted content is used in the `RUN` instruction, in such case there is no use of even pushing the cache since it will be never used by buildah. Make sure that stage executor attempts to push cache only if cacheKey is generated. Closes: containers#4647 Signed-off-by: Aditya R <arajan@redhat.com>
|
@nalind @containers/buildah-maintainers PTAL |
|
LGTM |
|
@blue42u PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buildah's layer caching does not generates cache key or uses a layer from store if
RUN --mountis used to make sure that always freshly mounted content is used in theRUNinstruction, in such case there is no use of even pushing the cache since it will be never used by buildah.Make sure that stage executor attempts to push cache only if cacheKey is generated.
Closes: #4647
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?