build --all-platforms: skip some base "image" platforms #5335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
kind/bug
nalind
force-pushed
the
only-most-platforms
branch
from
98a6d4f to
48605c1
Compare
When figuring out which platforms the base images allow us to build derived images for, screen out any images with non-empty artifactType values. Also screen out any which use empty values or the word "unknown" in the OS and Architecture platform fields, and any Architecture values that the compiler hasn't heard of. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
only-most-platforms
branch
from
48605c1 to
98f8707
Compare
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When figuring out which platforms the base images allow us to build derived images for, screen out any images with non-empty artifactType values. Also screen out any which use empty values or the word "unknown" in the OS and Architecture platform fields, and any Architecture values that the compiler hasn't heard of.
How to verify it
New integration test!
Which issue(s) this PR fixes:
Fixes #5331.
Special notes for your reviewer:
An alternate to the approach taken by #5334.
Does this PR introduce a user-facing change?