Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Add comment re: Total Success task name #5342

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

cevich
Copy link
Member

@cevich cevich commented Feb 16, 2024

What type of PR is this?

/kind other

What this PR does / why we need it:

Add important comment and link reminding maintainers not to change the success-aggregation task name.

How to verify it

N/A

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Previously it was possible for tide to merge a PR w/ a canceled "Total Success". Please wait for openshift/release#48909 to merge. A half-day after that, the tide bot will begin respecting the "Total Success" Cirrus-CI task status. Just so long as nobody ever changes the task name 😃

Does this PR introduce a user-facing change?

None

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cevich
Copy link
Member Author

cevich commented Feb 19, 2024

Thanks guys. Leaving this a draft until the openshift-ci PR merges (dunno how long that typically takes).

@cevich
Copy link
Member Author

cevich commented Feb 27, 2024

Marking this ready since the OS-CI config PR has merged. A similar same change was made in podman-CI and is well tested.

@containers/buildah-maintainers FYI: /hold is longer be required here. The tide bot will always wait for a green check on Total Success.

Edit: It will take up to 6-hours after openshift/release#48909 for the actual update to the bot to happen.

@cevich cevich marked this pull request as ready for review February 27, 2024 18:02
Signed-off-by: Chris Evich <cevich@redhat.com>
@edsantiago
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 27, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e5540d2 into containers:main Feb 27, 2024
8 of 22 checks passed
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants