-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] Add comment re: Total Success task name #5342
Conversation
Ephemeral COPR build failed. @containers/packit-build please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks guys. Leaving this a draft until the openshift-ci PR merges (dunno how long that typically takes). |
Marking this ready since the OS-CI config PR has merged. A similar same change was made in podman-CI and is well tested. @containers/buildah-maintainers FYI: /hold is longer be required here. The Edit: It will take up to 6-hours after openshift/release#48909 for the actual update to the bot to happen. |
Signed-off-by: Chris Evich <cevich@redhat.com>
2a7741f
to
26d5b84
Compare
/lgtm |
e5540d2
into
containers:main
What type of PR is this?
/kind other
What this PR does / why we need it:
Add important comment and link reminding maintainers not to change the success-aggregation task name.
How to verify it
N/A
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Previously it was possible for tide to merge a PR w/ a canceled "Total Success". Please wait for openshift/release#48909 to merge. A half-day after that, the
tide
bot will begin respecting the "Total Success" Cirrus-CI task status. Just so long as nobody ever changes the task name 😃Does this PR introduce a user-facing change?