-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] Revert "Reduce official image size" #5350
Conversation
Fixes: containers#5349 Unanticipated missing `dnf` functionality likely negatively impacts a significant number of image users. Further exploration of size reduction is needed, but we cannot (likely) swap to `microdnf` easily. This reverts commit cdb1a4f. Signed-off-by: Chris Evich <cevich@redhat.com>
LGTM |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@TomSweeneyRedHat mind popping one more slash-lgtm on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Hey there, the revert commit has not yet been applied to the RedHat Repository. |
@cevich do you have a way to repush the image? I know it happens automatically every 24 hours, but I'm not sure what the actual time is for the update. |
The build finished and pushed at about 11:21am EST. Since the original change merged at 9am EST, with no version bumps, the run today should have overwritten all the affected tags. |
What type of PR is this?
/kind other
What this PR does / why we need it:
Unanticipated missing
dnf
functionality likely negatively impacts a significant number of image users. Further exploration of size reduction is needed, but we cannot (likely) swap tomicrodnf
easily.This reverts commit cdb1a4f.
How to verify it
Not required, this reverts to previous state.
Which issue(s) this PR fixes:
Fixes: #5349
Special notes for your reviewer:
Does this PR introduce a user-facing change?