Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Revert "Reduce official image size" #5350

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

cevich
Copy link
Member

@cevich cevich commented Feb 21, 2024

What type of PR is this?

/kind other

What this PR does / why we need it:

Unanticipated missing dnf functionality likely negatively impacts a significant number of image users. Further exploration of size reduction is needed, but we cannot (likely) swap to microdnf easily.

This reverts commit cdb1a4f.

How to verify it

Not required, this reverts to previous state.

Which issue(s) this PR fixes:

Fixes: #5349

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Fixes: containers#5349

Unanticipated missing `dnf` functionality likely negatively impacts a
significant number of image users.  Further exploration of size
reduction is needed, but we cannot (likely) swap to `microdnf` easily.

This reverts commit cdb1a4f.

Signed-off-by: Chris Evich <cevich@redhat.com>
@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm
/hold #for happy green test buttons

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, flouthoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Feb 21, 2024
@cevich
Copy link
Member Author

cevich commented Feb 21, 2024

/hold cancel

@cevich
Copy link
Member Author

cevich commented Feb 21, 2024

@TomSweeneyRedHat mind popping one more slash-lgtm on this?

Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 608c5ba into containers:main Feb 21, 2024
21 checks passed
@theShlork
Copy link

Hey there, the revert commit has not yet been applied to the RedHat Repository.
There only the 21 hour old Tags are present:
https://quay.io/repository/buildah/stable?tab=tags
Maby you can trigger the build system that it can be used again.
Thanks and Greetings :)

@TomSweeneyRedHat
Copy link
Member

@cevich do you have a way to repush the image? I know it happens automatically every 24 hours, but I'm not sure what the actual time is for the update.

@cevich
Copy link
Member Author

cevich commented Feb 22, 2024

The build finished and pushed at about 11:21am EST. Since the original change merged at 9am EST, with no version bumps, the run today should have overwritten all the affected tags.

@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yum not found in latest quay.io/buildah/stable release
4 participants