Add support for passing CDI specs to --device #5443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the passed-in source location is a symbolic link, dereference it, because the documentation says that's what we do. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Avoid generically referring to "the container" where it can be ambiguous that we're actually talking about the environment we set up for running a command for a RUN instruction or Run() call. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
openshift-ci
bot
added
kind/feature
nalind
force-pushed
the
cdi
branch
2 times, most recently
from
8e22ebe
to
7a46966
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add support for using CDI to resolve `--device` devices for RUN instructions during `buildah build`, `buildah from`, and `buildah run`, as `podman run` does. This generally requires that we stop resolving device specifications (arguments passed to --device) earlier and deferring that until it's time to run a process, because CDI wants to pick over those values, modify a runtime spec to set up the ones that it knows about, and then hand back the list of values that it doesn't know about. We don't want to do a dry run of this during CLI processing because that would create a window where the underlying hardware state could change, and that could produce some hard-to-diagnose errors. Being able to test this is going to require that we add the `--device` flag to `buildah run` (`--security-opt` affects how we build the container's layer, so it has to be done at `buildah from`). The default configured devices list is pulled in by CLI flag processing during `buildah from` and `buildah build`, so it doesn't also need to be explicitly passed to `buildah run` or the internal Run() method. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Describe --device in `buildah from` and `buildah run`, where it's new. Update the description of --device in `buildah build` to note that the device nodes are only there while RUN instructions are being run, and not to imply that they end up in the finished image. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
/lgtm |
|
/hold cancel |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add support for using CDI to resolve
--devicedevices for RUN instructions duringbuildah build,buildah from, andbuildah run, aspodman rundoes.This generally requires that we stop resolving device specifications (arguments passed to --device) earlier and deferring that until it's time to run a process, because CDI wants to pick over those values, modify a runtime spec to set up the ones that it knows about, and then hand back the list of values that it doesn't know about.
We don't want to do a dry run of this during CLI processing because that would create a window where the underlying hardware state could change, and that could produce some hard-to-diagnose errors.
Being able to test this is going to require that we add the
--deviceflag tobuildah run(--security-optaffects how we build the container's layer, so it has to be done atbuildah from).The default configured devices list is pulled in by CLI flag processing during
buildah fromandbuildah build, so it doesn't also need to be explicitly passed tobuildah runor the internalRun()method.How to verify it
New integration tests!
Which issue(s) this PR fixes:
Fixes #5432.
Special notes for your reviewer:
It's probably easier to review this commit by commit.
chrootisolation doesn't run hooks, so a CDI configuration that includes hooks won't work correctly.CDI: https://github.com/cncf-tags/container-device-interface
CDI for Nvidia GPUs: https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/latest/cdi-support.html
Does this PR introduce a user-facing change?