-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source-push: add support for --digestfile
#5454
source-push: add support for --digestfile
#5454
Conversation
I don't really want to go very far down the road of reimplementing every |
@nalind Ah I agree, I was wondering if there any other workaround to original #5399 , i was unable to find one and adding a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me
docs/buildah-source-push.1.md
Outdated
@@ -20,6 +20,10 @@ The [username[:password]] to use to authenticate with the registry if required. | |||
If one or both values are not supplied, a command line prompt will appear and the | |||
value can be entered. The password is entered without echo. | |||
|
|||
**--digestfile** *Digestfile* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Not a new thing but why is Digestfile capitalized? It's not a well known thing like Dockerfile...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed, I think it got copied from older man-page, will fix it up there as well.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Allow writing digest of the pushed source to the specified `digestfile` Closes: containers#5399 Signed-off-by: flouthoc <flouthoc.git@gmail.com>
faf2ed9
to
5b414ad
Compare
/lgtm |
/unhold |
Allow writing digest of the pushed source to the specified
digestfile
Closes: #5399
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Closes: #5399