Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address CVE-2024-3727 #5523

Conversation

TomSweeneyRedHat
Copy link
Member

Second try Vendor top of tree of c/image and c/common to address CVE-2024-1759

(Although at the moment, just c/image to see if that's better)

[NO NEW TESTS NEEDED]

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Second try Vendor top of tree of c/image and c/common to address CVE-2024-1759

Replaces containers#5522

[NO NEW TESTS NEEDED]

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/cve-2024-3727-main-try2 branch from 5fde83f to bbab575 Compare May 9, 2024 23:59
@TomSweeneyRedHat TomSweeneyRedHat changed the title WIP - Address CVE-2024-3727 Try 2 Address CVE-2024-3727 May 10, 2024
@TomSweeneyRedHat
Copy link
Member Author

Replaces #5522

@TomSweeneyRedHat
Copy link
Member Author

OK, I'm not sure what went on with the vendoring with the prior one, but this is looking better. Still issues with the packit-builds though.

@mheon
Copy link
Member

mheon commented May 10, 2024

LGTM

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

rawhide and eln are failing on unrelated dnf issues.

Copy link
Contributor

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [TomSweeneyRedHat,lsm5]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5
Copy link
Member

lsm5 commented May 10, 2024

/hold cancel

@openshift-merge-bot openshift-merge-bot bot merged commit 77f239a into containers:main May 10, 2024
30 of 34 checks passed
@TomSweeneyRedHat
Copy link
Member Author

@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants