Merge pull request #2066 from rhatdan/filter

Display same error as split

libimage/filters.go

@@ -88,6 +88,8 @@ func (r *Runtime) compileImageFilters(ctx context.Context, options *ListImagesOp
  return tree, nil
  }
 
+ filterInvalidValue := `invalid image filter %q: must be in the format "filter=value or filter!=value"`
+
  var wantedReferenceMatches, unwantedReferenceMatches []string
  filters := map[string][]filterFunc{}
  duplicate := map[string]string{}
@@ -101,7 +103,7 @@ func (r *Runtime) compileImageFilters(ctx context.Context, options *ListImagesOp
  } else {
  split = strings.SplitN(f, "=", 2)
  if len(split) != 2 {
- return nil, fmt.Errorf("invalid image filter %q: must be in the format %q", f, "filter=value or filter!=value")
+ return nil, fmt.Errorf(filterInvalidValue, f)
  }
  }
 
@@ -195,7 +197,7 @@ func (r *Runtime) compileImageFilters(ctx context.Context, options *ListImagesOp
  filter = filterBefore(until)
 
  default:
- return nil, fmt.Errorf("unsupported image filter %q", key)
+ return nil, fmt.Errorf(filterInvalidValue, key)
  }
  if negate {
  filter = negateFilter(filter)