Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider splitting up pkg/util into semantically-relevant subpackages #1654

Closed
mtrmac opened this issue Sep 14, 2023 · 3 comments · Fixed by #1657
Closed

Consider splitting up pkg/util into semantically-relevant subpackages #1654

mtrmac opened this issue Sep 14, 2023 · 3 comments · Fixed by #1657

Comments

@mtrmac
Copy link
Contributor

mtrmac commented Sep 14, 2023

See https://github.com/containers/skopeo/pull/2112/files : adding a call to util.ReadPassword triggers addition of several other unnecessary subpackages. (I am starting to think that a util subpackage is always a mistake because it will become a dependency magnet like this, caller of one small thing accrues several other unwanted dependencies.)

This is, of course, quite low-priority.

@rhatdan
Copy link
Member

rhatdan commented Sep 14, 2023

I agree lets break this into a series of subpackages.

@vrothberg
Copy link
Member

I am also supportive. Some files in Podman import 3 or more "util" or "utils" packages.

rhatdan added a commit to rhatdan/common that referenced this issue Sep 18, 2023
Fixes: containers#1654

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/common that referenced this issue Sep 18, 2023
Fixes: containers#1654

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/common that referenced this issue Sep 19, 2023
Fixes: containers#1654

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/common that referenced this issue Sep 19, 2023
Fixes: containers#1654

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@mtrmac
Copy link
Contributor Author

mtrmac commented Sep 20, 2023

Thanks @rhatdan .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants