Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/config: Add ocijail to the RuntimeSupportsJSON list #1579

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

dfr
Copy link
Contributor

@dfr dfr commented Jul 23, 2023

I added this support to ocijail a while ago but forgot to change the compiled-in default since I was overriding the value in my containers.conf.

I added this support to ocijail a while ago but forgot to change the
compiled-in default since I was overriding the value in my
containers.conf.

Signed-off-by: Doug Rabson <dfr@rabson.org>
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfr, Luap99, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 393ca94 into containers:main Jul 24, 2023
6 checks passed
@dfr dfr deleted the ocijail-json branch July 24, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants