Add Farms to config #1586
Add Farms to config #1586
Conversation
|
@vrothberg @rhatdan PTAL |
|
Carrying over my comment from the Podman PR: I mean that it should not be part of the [engine] table but a new [buildfarm] table. Ideally, it should not be part of containers.conf at all but a proper database or a dedicated predictable path for root and rootless. machine and conenction are (ab)using containers.conf already as a database but there is growing desire to change that, see #1566. containers.conf is a config file for users and we somehow abuse it as a database. |
|
I agree this should at least be in a separate containers.conf file that can be updated on the fly. Moving everything to a dedicated connections.conf would be preferred to share both. |
I suggest to integrate buildfarm into the brainstorming in #1566. I think it's a bad idea to use a config file as a DB. BUT adding buildfarm as done in this PR will not change the status quo since we're already using containers.conf as a DB. It would be nice to find a more elegant solution in the future but we shouldn't block buildfarm's progress on this issue. |
|
I updated the PR to create a separate |
umohnani8
force-pushed
the
farms
branch
2 times, most recently
from
786ebcb
to
5197889
Compare
umohnani8
force-pushed
the
farms
branch
8 times, most recently
from
3463236
to
bd68227
Compare
|
Tests are green! |
|
LGTM |
|
The Podman PR containers/podman#19358 doesn't pass CI yet. Let's wait to be sure this PR has everything containers/podman#19358 needs. |
Add two new fields Farms and DefaultFarm to the Config to be used by the new podman buildfarm command. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
A new --farm flag is being added to podman system connection add so that when a new connection is added it can be added to a new or existing farm. Update the code here to be able to do that. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
|
Added docs |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, umohnani8, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add 2 new fields to EngineConfig
FarmsandDefaultFarmfor the podman buildfarm feature work.Also update the ssh connection code to be able to add a new connection to a new or existing farm when the
--farmis set inpodman system connection add.PR containers/podman#19358 will vendor this in.