Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libimage: add compat interfaces for the new platform subpackage #1696

Merged
merged 1 commit into from
Oct 13, 2023
Merged

libimage: add compat interfaces for the new platform subpackage #1696

merged 1 commit into from
Oct 13, 2023

Conversation

nalind
Copy link
Member

@nalind nalind commented Oct 12, 2023

Add compatibility interfaces for items which have been moved from the main libimage package to its new platform subpackage.

@nalind
libimage: add compat interfaces for the new platform subpackage
14f1d70 
Add compatibility interfaces for items which have been moved from the
main libimage package to its new platform subpackage.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@nalind nalind mentioned this pull request Oct 12, 2023
Merged
@rhatdan
Copy link
Member

rhatdan commented Oct 12, 2023

LGTM
I am fine with this but up til now we did not guarantee the interfaces for common.

vrothberg
vrothberg approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nalind, I am sure you noticed something breaking. Did the platform policy leak into some stable interface somewhere?

@openshift-ci openshift-ci bot added the lgtm label Oct 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nalind, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg
Copy link
Member

/hold

@openshift-ci openshift-ci bot merged commit 9f2f68b into containers:main Oct 13, 2023
7 checks passed
@nalind nalind deleted the compat-platform branch October 13, 2023 13:27
@nalind
Copy link
Member Author

nalind commented Oct 13, 2023

/lgtm

@nalind, I am sure you noticed something breaking. Did the platform policy leak into some stable interface somewhere?

Not specifically; this was mainly about the normalization function being moved, but why do we want to make it harder to drop a newer version of this library into an older version of something that uses it?

@vrothberg
Copy link
Member

[...] but why do we want to make it harder to drop a newer version of this library into an older version of something that uses it?

I don't think we want to make it explicitly harder. There's no stability guarantee (yet?) which gives us the freedom to break things when needed. But for sure I agree that we should avoid breaking whenever possible. In this specific case, I do not feel strongly either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrothberg vrothberg vrothberg approved these changes

Assignees

@vrothberg vrothberg

Labels
approved do-not-merge/hold lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nalind @rhatdan @vrothberg