libimage: Untag should error for non existent name #1701
Conversation
podman untag should error out of a name is given which does not exists for the given image. This regression was added in commit 465dd3e. There was even a test which meant to check for it but unfortunately it did not actually check for what it should. The doNotExist check failed early to the upper case in the repo name. The tests have been updated to check for actual error messages to show ensure it is failing for the right reason. This also showed that `normalizing name` message was included twice so I removed one case to not stutter. Fixes 465dd3e ("libimage: support parallel tag/untag") Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -587,6 +587,9 @@ func (i *Image) Tag(name string) error { | |||
| return i.reload() | |||
| } | |||
|
|
|||
| // to have some symmetry with the errors from containers/storage. | |||
| var errTagUnknown = errors.New("tag not known") | |||
There was a problem hiding this comment.
Should this be exported in libimage/define?
There was a problem hiding this comment.
I don´t think we need to. I cannot think of a scenario where users shouldn't error out.
There was a problem hiding this comment.
this is c/common so no and it just brings back the error removed in 465dd3e.
I don't see the need to export it unless someone wants to match on this specific error but for now this is not the case and we can always export it later if needed
|
/lgtm |
podman untag should error out of a name is given which does not exists for the given image. This regression was added in commit 465dd3e.
There was even a test which meant to check for it but unfortunately it did not actually check for what it should. The doNotExist check failed early to the upper case in the repo name.
The tests have been updated to check for actual error messages to show ensure it is failing for the right reason.
This also showed that
normalizing namemessage was included twice so I removed one case to not stutter.Fixes 465dd3e ("libimage: support parallel tag/untag")