Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update module github.com/opencontainers/runc to v1.1.10 #1743

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Nov 18, 2023

No description provided.

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Copy link
Contributor

openshift-ci bot commented Nov 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member Author

rhatdan commented Nov 19, 2023

@giuseppe
Copy link
Member

Last time I've tried, it bloated the podman binary as it brings in the new ebpf dependency.

Could you open a PR with Podman to verify that?

@rhatdan
Copy link
Member Author

rhatdan commented Nov 20, 2023

/hold

No reason to test with POdman, can see this pulled in ebpf now.

@rhatdan
Copy link
Member Author

rhatdan commented Nov 20, 2023

@giuseppe have you attempted to work with @kolyshkin to move the requirement?

@giuseppe
Copy link
Member

I am fine to merge this as it is just affecting c/common, but we can't drop the replace in podman as it affects the binary size.

I proposed a potential fix for runc, but it was not accepted: opencontainers/runc#4005

@rhatdan
Copy link
Member Author

rhatdan commented Nov 20, 2023

Ok let's merge here.

@openshift-merge-bot openshift-merge-bot bot merged commit 37f046e into containers:main Nov 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants