Allow searching $TZDIR for timezone data
#1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glibc supports the environment variable as additional search path. We now add this to the config validation to allow runtimes to search that path as well. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
added a commit
to saschagrunert/podman
that referenced
this pull request
Dec 20, 2023
glibc supports the environment variable as additional search path, means we allow to override the `/usr/share/zoneinfo` path by setting the variable. Analogous change to containers/common#1772 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
added a commit
to saschagrunert/podman
that referenced
this pull request
Dec 20, 2023
glibc supports the environment variable as additional search path, means we allow to override the `/usr/share/zoneinfo` path by setting the variable. Analogous change to containers/common#1772 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
added a commit
to saschagrunert/podman
that referenced
this pull request
Dec 20, 2023
glibc supports the environment variable as additional search path, means we allow to override the `/usr/share/zoneinfo` path by setting the variable. Analogous change to containers/common#1772 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
added a commit
to saschagrunert/podman
that referenced
this pull request
Dec 20, 2023
glibc supports the environment variable as additional search path, means we allow to override the `/usr/share/zoneinfo` path by setting the variable. Analogous change to containers/common#1772 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Shit. I should've blocked this. @saschagrunert I trust you'll submit a new PR? |
saschagrunert
added a commit
to saschagrunert/common
that referenced
this pull request
Dec 21, 2023
The TZDIR environment variable override the lookup paths and does not append them. This patch fixes that behavior and is a follow-up on: containers#1772 Ref: containers/podman#21063 (comment) Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
added a commit
to saschagrunert/common
that referenced
this pull request
Dec 21, 2023
The TZDIR environment variable override the lookup paths and does not append them. This patch fixes that behavior and is a follow-up on: containers#1772 Ref: containers/podman#21063 (comment) Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
|
@edsantiago sure: #1774 |
saschagrunert
added a commit
to saschagrunert/common
that referenced
this pull request
Dec 21, 2023
The TZDIR environment variable override the lookup paths and does not append them. This patch fixes that behavior and is a follow-up on: containers#1772 Ref: containers/podman#21063 (comment) Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glibc supports the environment variable as additional search path. We now add this to the config validation to allow runtimes to search that path as well.