-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default image volume mode to "anonymous" #1820
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Needed for containers/podman#21339 |
2001192
to
1e5675c
Compare
@dfr FYI, it looks like this undoes a previous FreeBSD change, but as long as there is volume support in Podman on FreeBSD it shouldn't break anything. |
We have not supported type=bind image volumes since pre-1.0 Podman - we phased them out when we added support for actual volumes. Also, our image volume valid modes checker did not even allow the actual default (anonymous). This is technically a breaking change, so it will go into Podman 5.0 - but I strongly doubt anyone is actually using this field if no one has noticed this issue before now. Signed-off-by: Matt Heon <mheon@redhat.com>
1e5675c
to
92e64c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'll take a look and make sure it doesn't affect volume support on FreeBSD |
@dfr Any update? I'd like to get this merged this week. |
I believe that this change won't affect FreeBSD - podman contains code which substitutes |
TY! |
/approve |
/lgtm |
We have not supported type=bind image volumes since pre-1.0 Podman - we phased them out when we added support for actual volumes. Also, our image volume valid modes checker did not even allow the actual default (anonymous). This is technically a breaking change, so it will go into Podman 5.0 - but I strongly doubt anyone is actually using this field if no one has noticed this issue before now.