Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor c/storage, c/image @main #1829

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Conversation

ashley-cui
Copy link
Member

Fixes a windows config lookup issue.

Fixes a windows config lookup issue.

Signed-off-by: Ashley Cui <acui@redhat.com>
@mheon
Copy link
Member

mheon commented Jan 29, 2024

Looks like we have changes in the c/storage API, this doesn't build

@rhatdan
Copy link
Member

rhatdan commented Jan 29, 2024

See if you can vendor in latest containers/image at same time.

Signed-off-by: Ashley Cui <acui@redhat.com>
@ashley-cui ashley-cui changed the title Vendor c/storage@main Vendor c/storage, c/image @main Jan 29, 2024
@mheon
Copy link
Member

mheon commented Jan 29, 2024

Yay. It's working.
LGTM

@baude
Copy link
Member

baude commented Jan 29, 2024

/hold
/lgtm

@baude
Copy link
Member

baude commented Jan 29, 2024

/approve
/hold cancel

Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui, baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3310a75 into containers:main Jan 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants