Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump c/storage to v1.53.0, c/image to v5.30.0, and common to v0.58.0, then to v0.59.0-dev #1886

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Bump c/storage to v1.53.0, c/image to v5.30.0, and common to v0.58.0, then to v0.59.0-dev #1886

merged 3 commits into from
Mar 6, 2024

Conversation

TomSweeneyRedHat
Copy link
Member

The third vendor dance step for Podman v5.0.

Bump c/storage to v1.53.0, c/image to v5.30.0, and then c/common to v0.58.0. Finally bump common to a dev branch

[NO NEW TESTS NEEDED]

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 5, 2024
@mheon
Copy link
Member

mheon commented Mar 5, 2024

LGTM

mtrmac
mtrmac reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luap99
Copy link
Member

Luap99 commented Mar 5, 2024

Lint failing

  level=error msg="Running error: 1 error occurred:\n\t* can't run linter goanalysis_metalinter: buildssa: failed to load package manifests: could not load export data: no export data for \"github.com/containers/common/libimage/manifests\"\n\n"

No idea what this means but it also failed on #1885

@Luap99
Copy link
Member

Luap99 commented Mar 5, 2024

still failing 😞

@TomSweeneyRedHat
Copy link
Member Author

I've rebased, repushed after #1889 from @Luap99 was merged, and still I'm seeing the same error it appears.

  level=error msg="Running error: can't run linter goanalysis_metalinter\nbuildssa: failed to load package manifests: could not load export data: no export data for \"github.com/containers/common/libimage/manifests\""
  level=info msg="Memory: 209 samples, avg is 717.2MB, max is 945.1MB"

@Luap99
Copy link
Member

Luap99 commented Mar 5, 2024

I can take a closer look tomorrow morning if you haven't been able to figure it out by then.

@mtrmac
Copy link
Contributor

mtrmac commented Mar 5, 2024

I have manually deleted caches matching go.mod’s SHA1 (c4012c9674c2c305631ed986af141f806a35e8f4 ) in https://github.com/containers/common/actions/caches , that didn’t make a difference.

@mtrmac
Copy link
Contributor

mtrmac commented Mar 5, 2024

@TomSweeneyRedHat I’ll need to leave this for today, one possible avenue to explore.

golangci/golangci-lint#1920 suggests a Go version mismatch as a possibility — the lint is running Go 1.19, while go.mod requires 1.20.

@edsantiago
Copy link
Member

It does look like go-1.21 is the next step, but that might mean having to use Cirrus instead of GitHub Actions.

TomSweeneyRedHat added a commit to TomSweeneyRedHat/image that referenced this pull request Mar 5, 2024
@TomSweeneyRedHat
[WIP] Add Linters
b9b9b50 
This PR in c/common: containers/common#1886 is
failing.  The best I can figure out, something in c/image is causes
lint to error out without much information.

I'm trying to add the same linters that c/common uses to this repo
to see if it will find what's what.

Do not Merge this at this time.

[NO NEW TESTS NEEDED]
Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
@TomSweeneyRedHat TomSweeneyRedHat mentioned this pull request Mar 5, 2024
Closed
@Luap99
Copy link
Member

Luap99 commented Mar 6, 2024

This #1890 will update the go version and it works in my testing PR #1891

@TomSweeneyRedHat
Bump c/storage to v1.53.0, c/image to v5.30.0
3feb88c 
As the title says.  The third step in the vendor dance.
Bumps c/storage v1.53.0 and c/image to v5.30.0 all in
preparation of Podman v5.0

[NO NEW TESTS NEEDED]

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
@TomSweeneyRedHat
Bump to v0.58.0
e58240a 
As the title says.  In preparation of Podman v5.0,
bumping to v0.58.0.

[NO NEW TESTS NEEDED]

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
@TomSweeneyRedHat
Bump to v0.59.0-dev
3428c9a 
As the title say, bumping to the next dev version.

[NO NEW TESTS NEEDED]

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
@TomSweeneyRedHat
Copy link
Member Author

Repushed, and through the lint test!

@Luap99
Copy link
Member

Luap99 commented Mar 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 51ddf50 into containers:main Mar 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrmac mtrmac mtrmac left review comments

Assignees

@Luap99 Luap99

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomSweeneyRedHat @mheon @Luap99 @mtrmac @edsantiago