Simplify PullPolicy handling #1922
Conversation
pkg/config/config_test.go
Outdated
| policy: PullPolicyNewer, | ||
| }, | ||
| { | ||
| value: "NEVER", |
There was a problem hiding this comment.
| value: "NEVER", | |
| value: "NEWER", |
Also needs IFNEWER,
There was a problem hiding this comment.
These are fixed in current PR.
|
@mheon @edsantiago @Luap99 @cevich Any idea what is blowing up here? |
pkg/config/config_test.go
Outdated
| p, err := ParsePullPolicy(test.value) | ||
| if test.fail { | ||
| gomega.Expect(err.Error()).To(gomega.Equal(fmt.Sprintf("unsupported pull policy %q", test.value))) | ||
|
|
There was a problem hiding this comment.
gofumpt is barfing about this blank line
|
Followup for future reference. The error is:
Easy enough to install and run |
|
So there is something wrong with the VM image? Or is there something wrong with my PR? |
|
See my inline comment in your diff. I believe this strict linter is catching something that |
Add support for ifmissing Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
The way the tool indicated this problem was to throw up in the logs about missing packages, which is very confusing. |
|
@edsantiago @vrothberg @Luap99 PTAL |
|
One more comment from @vrothberg is still relevant. Once that's addressed LGTM |
|
@vrothberg PTAL I think I Have addressed all your issues. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Add support for ifmissing