Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows config path regression #2027

Merged
merged 1 commit into from
May 30, 2024

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented May 30, 2024

The path no longer included the path separator between the env and our config dir. The regression was added in commit 6c651df.

Fixes #2025

The path no longer included the path separator between the env and our
config dir. The regression was added in commit 6c651df.

Fixes containers#2025

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99
Copy link
Member Author

Luap99 commented May 30, 2024

@l0rd @rhatdan @mheon PTAL

@mheon
Copy link
Member

mheon commented May 30, 2024

LGTM

Copy link
Member

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: l0rd, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mheon
Copy link
Member

mheon commented May 30, 2024

/lgtm
/cherry-pick v0.59

@openshift-ci openshift-ci bot added the lgtm label May 30, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 08629a6 into containers:main May 30, 2024
12 checks passed
@Luap99 Luap99 deleted the winpath branch May 30, 2024 16:55
@Luap99 Luap99 mentioned this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect podman-connections.json path in Windows
3 participants