Trivial patches to minimize patches needed by NetBSD #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ephemeral COPR build failed. @containers/packit-build please check. |
coypoop
force-pushed
the
trivial-netbsd-patches
branch
from
4d2b295 to
a6693e6
Compare
Signed-off-by: Maya Rashish <maya@NetBSD.org>
NetBSD allows build-time configuration of paths, so will need to patch this file anyway, but not needing to create a new file will be easier. Signed-off-by: Maya Rashish <maya@NetBSD.org>
|
LGTM. @dfr PTAL. |
|
LGTM, thanks! You might want to add to the build-cross target in Makefile so that we can pick up netbsd build breaks in CI. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coypoop, lsm5, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks, I've been patching your repo to build podman on NetBSD.
The resulting podman seems to work well enough.
(Needs containers/storage#1935 too, and a hack to overcome an issue with the unix package not having SEEK_SET defined on NetBSD)