[skip-ci] RPM: fix netavark dependency epoch #2071
Conversation
|
i'll change the netavark_epoch a bit. Hold off on review. |
netavark and aardvark-dns dependencies have updated Epoch, we need to handle them correctly in containers-common. Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
|
ready for review. PTAL |
|
LGTM |
|
So I assume this means that aardvark-dns, netavark, containers-common must be updated together in the same bohdi to not cause conflicts? |
No. containers-common can still go in separately as long as we have the We could even remove the min epoch:version-release so that it will fetch the latest available for new installs / system upgrades. Removing the min version can prevent us from enforcing upgrades where required, but it can make things convenient for maintenance. FWIW, the podman package enforces no min-version on containers-common-extra dependency currently. The netavark dependency before this diff didn't have epoch which worked fine for official Fedora as epoch was 0, but with RHEL conditionals included, this epoch will be needed. |
err, if we need to enforce min dep on the latest netavark that's yet to land in fedora, then we gotta be careful, maybe release in order (first netavark, then c/common). |
|
Btw, packit people are working on |
|
I think handling these dependencies in rpm should be accounted for in the upcoming release process spike. |
|
/lgtm |
|
@jnovy: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jnovy, lsm5, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
netavark and aardvark-dns dependencies have updated Epoch, we need to handle them correctly in containers-common.