Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-ci] Packit: isolate rhel jobs from centos #2076

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Jul 1, 2024

This allows centos stream jobs to be triggered for PRs by authors who don't have commit access to the repo.

This allows centos stream jobs to be triggered for PRs by authors who
don't have commit access to the repo.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
Copy link
Member Author

lsm5 commented Jul 1, 2024

Need to include all active fedora targets.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5 lsm5 marked this pull request as draft July 1, 2024 18:55
@lsm5 lsm5 marked this pull request as ready for review July 1, 2024 19:01
Without `packages: containers-common-fedora`, packit will trigger build
jobs for all package values.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Jul 2, 2024

LGtm

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9f2abdf into containers:main Jul 4, 2024
14 checks passed
@lsm5 lsm5 deleted the packit-isolate-rhel branch July 11, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants