Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the environment variables for the engine #828

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Nov 15, 2021

The Engine.Env needs to be set very early in the setup process
to make sure no one attempts to use the environment.

Fixes: containers/podman#12296

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

The Engine.Env needs to be set very early in the setup process
to make sure no one attempts to use the environment.

Fixes: containers/podman#12296

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan
Copy link
Member Author

rhatdan commented Nov 15, 2021

@containers/podman-maintainers PTAL

@umohnani8
Copy link
Member

LGTM

Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 72166a4 into containers:main Nov 15, 2021
@edsantiago
Copy link
Member

Rats, got here too late. I would've liked to see a test case for the already-in-environment override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman pull ignores a TMPDIR override in containers.conf
6 participants