Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ptrace as a default seccomp allow to match Docker #973

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Add ptrace as a default seccomp allow to match Docker #973

merged 1 commit into from
Mar 23, 2022

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Mar 22, 2022

Also sort all syscalls in alphabetic order.

Fixes: containers/buildah#3833

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

@nalind
Copy link
Member

nalind commented Mar 22, 2022

ptrace is already allowed or denied based on whether or not CAP_SYS_PTRACE is set.

@rhatdan
Copy link
Member Author

rhatdan commented Mar 22, 2022

Docker allows it by default, and CAP_SYS_PTRACE allows one process to PTRACE processes owned by other UIDs, while ptrace allows a process to ptrace your own UID, so they are not equivalent.

@nalind
Copy link
Member

nalind commented Mar 22, 2022

It shouldn't be listed as always-allowed, which this patch adds, while it's still conditional elsewhere in the configuration. At best, that's confusing.

@rhatdan rhatdan force-pushed the seccomp branch 2 times, most recently from ede2108 to e265929 Compare March 22, 2022 21:10
@rhatdan
Add ptrace as a default seccomp allow to match Docker
d3c1d95 
Also sort all syscalls in alphabetic order.

Fixes: containers/buildah#3833

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
giuseppe
giuseppe approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

flouthoc
flouthoc approved these changes Mar 23, 2022
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vrothberg
vrothberg approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, giuseppe, rhatdan, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [giuseppe,rhatdan,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6f3894b into containers:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseppe giuseppe giuseppe approved these changes

@flouthoc flouthoc flouthoc approved these changes

@vrothberg vrothberg vrothberg approved these changes

Assignees

@vrothberg vrothberg

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Podman build random number seed problem
6 participants
@rhatdan @nalind @giuseppe @flouthoc @vrothberg @openshift-merge-robot