Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA ci with fsverity #389

Open
cgwalters opened this issue Oct 29, 2024 · 4 comments
Open

GHA ci with fsverity #389

cgwalters opened this issue Oct 29, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@cgwalters
Copy link
Contributor

Previously I added a hacky loopback mounted ext4, but in some quick testing I noticed that testing via the default GHA runner just needs tune2fs -O verity /dev/sda1 for reference.

We should be able to rework some of our tests to use this.

@cgwalters cgwalters added the enhancement New feature or request label Oct 29, 2024
@allisonkarlitskaya
Copy link
Collaborator

Previously I added a hacky loopback mounted ext4, but in some quick testing I noticed that testing via the default GHA runner just needs tune2fs -O verity /dev/sda1 for reference.

We should be able to rework some of our tests to use this.

I hit this same issue in composefs_experiments and solved it the same way (loopback-mounted verity-enabled ext4). I specifically wanted to avoid the tune2fs approach because it hardcodes the name of the root device which could maybe change.

@cgwalters
Copy link
Contributor Author

Sure, just replace /dev/sda1 with $(findmnt -vno SOURCE /)

@allisonkarlitskaya
Copy link
Collaborator

That's something I could get behind :)

allisonkarlitskaya added a commit to containers/composefs-rs that referenced this issue Oct 29, 2024
...instead of using an extra loopback partition.

Suggested by Colin in containers/composefs#389.
allisonkarlitskaya added a commit to containers/composefs-rs that referenced this issue Oct 29, 2024
...instead of using an extra loopback partition.

Suggested by Colin in containers/composefs#389.
allisonkarlitskaya added a commit to containers/composefs-rs that referenced this issue Oct 29, 2024
...instead of using an extra loopback partition.

Suggested by Colin in containers/composefs#389.
@allisonkarlitskaya
Copy link
Collaborator

Works great. Just did this in containers/composefs-rs#19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants