Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mount: Support EROFS file-backed mounts #403

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Conversation

ruihe774
Copy link
Contributor

@ruihe774 ruihe774 commented Dec 19, 2024

It turns out we can directly mount /dev/fd/$fd, so current API does not need to be changed.

Closes: #361
Closes: #144

Copy link
Collaborator

@allisonkarlitskaya allisonkarlitskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using this feature would be quite nice. composefs-rs does it only this way (with no support for older kernels).

Here's a couple of immediate issues I noticed:

libcomposefs/lcfs-mount.c Outdated Show resolved Hide resolved
libcomposefs/lcfs-mount.c Show resolved Hide resolved
@ruihe774 ruihe774 changed the title [POC] mount: Support EROFS file-backed mounts mount: Support EROFS file-backed mounts Dec 19, 2024
Signed-off-by: Misaki Kasumi <misakikasumi@outlook.com>
Copy link
Contributor

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cgwalters
Copy link
Contributor

I'm marking this as closing both of the outstanding issues we have around loopback.

Copy link
Contributor

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cgwalters
Copy link
Contributor

Hm, technically the merge settings right now require the person who marked things as "requested changes" to switch to approval but I can see you've addressed those changes.

@cgwalters cgwalters merged commit 14ad6b9 into containers:main Dec 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mount: add support for optionally skipping loopback device better loopback handling (hiding it)
3 participants