The spec file refers to missing license files #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the upstream spec unusable. Also adding missing License tag. Signed-off-by: Jindrich Novy <jnovy@redhat.com>
cgwalters
approved these changes
Jan 6, 2025
|
Thanks for merging this @cgwalters I still think there is a value in maintaining the spec file for RPM based distros. We do the same for podman, etc. I volunteer to maintain this for you if you are cool with it. |
In practice though isn't the spec often file different for e.g. OpenSUSE? And my experience is it even drifts between Fedora and CentOS/RHEL pretty quickly. But anyways it would totally make sense to use the same automation that podman uses (does it use packit today?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec file refers to missing license files making making the upstream spec unusable. Also adding missing License tag.