Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference podman-next project for main packit builds #1109

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind ci

What this PR does / why we need it:

Refering to #1108 (comment) and #1108 (comment), we now reference the project podman-next when building packages for main.

Which issue(s) this PR fixes:

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

PTAL @haircommander @lsm5 @rphillips

@codecov-commenter
Copy link

Codecov Report

Merging #1109 (6328a33) into main (7b2a32a) will decrease coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1109      +/-   ##
==========================================
- Coverage   33.51%   33.42%   -0.09%     
==========================================
  Files          13       13              
  Lines        1119     1119              
  Branches      387      391       +4     
==========================================
- Hits          375      374       -1     
  Misses        487      487              
- Partials      257      258       +1     

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

🤞

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member Author

/unhold

@openshift-merge-robot openshift-merge-robot merged commit c552187 into containers:main Feb 15, 2023
@lsm5
Copy link
Member

lsm5 commented Feb 15, 2023

ugh, i forgot to add some settings to the podman-next copr. let me do that now.

@lsm5
Copy link
Member

lsm5 commented Feb 15, 2023

/packit copr-build

@saschagrunert saschagrunert deleted the podman-next branch February 15, 2023 10:43
@saschagrunert
Copy link
Member Author

Thank you @lsm5 !

@lsm5
Copy link
Member

lsm5 commented Feb 15, 2023

Thank you @lsm5 !

don't thank me yet 😄 . Looks like it's still sending the trigger:commit build to the packit-builds copr and not the podman-next corp ☹️ . Let me look further..

@lsm5
Copy link
Member

lsm5 commented Feb 15, 2023

i'm gonna try deleting the conmon-rs package from podman-next and try a packit copr-build to see if it gets picked up.

@lsm5
Copy link
Member

lsm5 commented Feb 15, 2023

/packit copr-build

@lsm5
Copy link
Member

lsm5 commented Feb 15, 2023

@saschagrunert so slash-packit copr-build will trigger for pull_request not once merged. To see the main branch get built on podman-next, we gotta do another PR. I now the packit forge setting enabled, so I think we should be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants