Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] nit: fix typo #1112

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Feb 15, 2023

What type of PR is this?

/kind other

What this PR does / why we need it:

Typo fix in comment. Also helps to check if packit builds are triggered on rhcontainerbot/podman-next copr after commit on main branch.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
@lsm5
Copy link
Member Author

lsm5 commented Feb 15, 2023

🤞

@codecov-commenter
Copy link

Codecov Report

Merging #1112 (7284e22) into main (8797905) will increase coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1112      +/-   ##
==========================================
+ Coverage   33.69%   33.78%   +0.08%     
==========================================
  Files          13       13              
  Lines        1119     1119              
  Branches      391      391              
==========================================
+ Hits          377      378       +1     
  Misses        487      487              
+ Partials      255      254       -1     

@lsm5
Copy link
Member Author

lsm5 commented Feb 15, 2023

@saschagrunert PTAL. This should be it 😄

@lsm5
Copy link
Member Author

lsm5 commented Feb 15, 2023

ha, we didn't even need this PR, it's already triggered: https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/build/5528574/ . So we're all set!

@lsm5
Copy link
Member Author

lsm5 commented Feb 15, 2023

btw, f36 builds are failing. If you don't care about f36 (like me), I can try disabling it for conmon-rs, but that may not work yet: packit/packit-service#1903

@rphillips
Copy link
Collaborator

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4973370 into containers:main Feb 15, 2023
@lsm5 lsm5 deleted the typo-fix branch February 15, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants