Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packit: Fix sed for release tag update in rpm spec #1174

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Mar 9, 2023

Resolves: #1173

What type of PR is this?

/kind other

What this PR does / why we need it:

Fixes rpm release tag in copr builds

Which issue(s) this PR fixes:

#1173

Fixes #1173

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Resolves: containers#1173

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
@lsm5
Copy link
Member Author

lsm5 commented Mar 9, 2023

release tag looking good on the in-progress packit build https://copr.fedorainfracloud.org/coprs/rhcontainerbot/packit-builds/build/5618822/

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit 873ef47 into containers:main Mar 9, 2023
@lsm5 lsm5 deleted the copr-fix-release-tag branch March 10, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rhcontainerbot/podman-next copr] conmon-rs builds have the same release tag
3 participants