-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cosign signature check #1255
Update cosign signature check #1255
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7d9f173
to
bd087a5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1255 +/- ##
==========================================
- Coverage 34.39% 33.86% -0.54%
==========================================
Files 13 13
Lines 1128 1128
Branches 387 389 +2
==========================================
- Hits 388 382 -6
- Misses 480 490 +10
+ Partials 260 256 -4 |
a2b9ff2
to
fb9a3e3
Compare
The check of the cosign-based keyless signature check accepted any valid signature. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
fb9a3e3
to
d1c2600
Compare
@saschagrunert is this ready? |
@haircommander yes, but it looks like we have a RPM build issue (unrelated to this PR, though). |
/lgtm |
/retest-required |
/test rpm-build:centos-stream-9-x86_64 |
@rphillips: No presubmit jobs available for containers/conmon-rs@main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Tried the RPM builds again on Friday. Failed with GPG packaging key errors:
|
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The check of the cosign-based keyless signature check accepted any valid signature.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?