Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Rust to v1.69.0 #1567

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind ci

What this PR does / why we need it:

We can also remove the build constraints from the Cargo.toml file since we have updated them in the past.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Updated latest required Rust version to v1.69.0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #1567 (5006162) into main (bbf4eea) will increase coverage by 0.88%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1567      +/-   ##
==========================================
+ Coverage   33.95%   34.83%   +0.88%     
==========================================
  Files          13       13              
  Lines        1134     1134              
  Branches      391      392       +1     
==========================================
+ Hits          385      395      +10     
+ Misses        493      483      -10     
  Partials      256      256              

@saschagrunert saschagrunert changed the title Bump rust to v1.69.0 Bump Rust to v1.69.0 Aug 9, 2023
@rphillips
Copy link
Collaborator

/lgtm

@rphillips
Copy link
Collaborator

@saschagrunert needs a rebase

We can also remove the build constraints from the `Cargo.toml` file
since we have updated them in the past.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

Rebased 👍

@rphillips
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit d92a902 into containers:main Aug 9, 2023
28 checks passed
@saschagrunert saschagrunert deleted the rust branch August 9, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants