Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for git diff after build #1673

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Sep 5, 2023

What type of PR is this?

/kind ci

What this PR does / why we need it:

This allows to detect possible required changes to Cargo.lock, for example when bumping the crate version.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Requires #1664

Does this PR introduce a user-facing change?

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This allows to detect possible required changes to Cargo.lock, for
example when bumping the crate version.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1673 (aa5f023) into main (3907eb8) will increase coverage by 0.17%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1673      +/-   ##
==========================================
+ Coverage   35.44%   35.62%   +0.17%     
==========================================
  Files          13       13              
  Lines        1151     1151              
  Branches      368      368              
==========================================
+ Hits          408      410       +2     
  Misses        505      505              
+ Partials      238      236       -2     

@haircommander
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit 4dc6973 into containers:main Sep 7, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants