Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for s390x #2037

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind ci

What this PR does / why we need it:

Add support for s390x arch.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added support for s390x for the static binaries.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2037 (83c93d9) into main (4e0f474) will decrease coverage by 0.08%.
Report is 113 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2037      +/-   ##
==========================================
- Coverage   37.53%   37.46%   -0.08%     
==========================================
  Files          15       15              
  Lines        1268     1268              
  Branches      414      415       +1     
==========================================
- Hits          476      475       -1     
  Misses        526      526              
- Partials      266      267       +1     

@saschagrunert
Copy link
Member Author

@kwilczynski
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

@kwilczynski: changing LGTM is restricted to collaborators

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rphillips
Copy link
Collaborator

/lgtm

@rphillips
Copy link
Collaborator

/test integration

Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

@rphillips: No presubmit jobs available for containers/conmon-rs@main

In response to this:

/test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips
Copy link
Collaborator

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 97dcff1 into containers:main Feb 28, 2024
36 checks passed
@saschagrunert saschagrunert deleted the s390x branch February 28, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants