-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build s390x binaries using musl libc #2144
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2144 +/- ##
==========================================
+ Coverage 37.53% 37.61% +0.07%
==========================================
Files 15 15
Lines 1268 1268
Branches 414 412 -2
==========================================
+ Hits 476 477 +1
+ Misses 526 525 -1
Partials 266 266 |
This will not work due to a s390x build failure:
/hold |
7f27e35
to
a9d1daf
Compare
Building using musl until NixOS/nixpkgs#306473 is resolved. Refers to cri-o/cri-o#7911 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
a9d1daf
to
ef35ef8
Compare
/unhold |
@haircommander PTAL. |
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Building using musl until NixOS/nixpkgs#306473 is resolved.
Which issue(s) this PR fixes:
Refers to cri-o/cri-o#7911
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?