-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go-capnp package to fix build issue on Go 1.23 #2317
Update go-capnp package to fix build issue on Go 1.23 #2317
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kwilczynski The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign kwilczynski |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2317 +/- ##
==========================================
- Coverage 37.53% 37.34% -0.20%
==========================================
Files 15 15
Lines 1268 1264 -4
Branches 414 421 +7
==========================================
- Hits 476 472 -4
+ Misses 526 524 -2
- Partials 266 268 +2 |
Integration tests seems to fail, do you know why? |
/close |
@kwilczynski: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/reopen |
@kwilczynski: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@saschagrunert, I will look into it. |
89243f6
to
1e4396d
Compare
@saschagrunert, I was able to narrow the failures down to the following change of the go-capnp package: Part of the following release: Neet to look whether we need to do something or whether this is a regression. |
a59b5e4
to
d5786ec
Compare
c13d651
to
ec23245
Compare
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
947f470
to
bdd2bb7
Compare
Yay, green CI! 🟢 |
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
@kwilczynski is this still WIP? |
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
bdd2bb7
to
d9afa0d
Compare
@saschagrunert, should be ready for review, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/approve |
@saschagrunert, do you think we could cut a new release? |
Yes, let me first check if we can / have to fix cri-o/cri-o#8411. I'm not even sure if that's a conmon-rs issue. |
@saschagrunert, the exit code and time out boolean value should be copied so the correct exit code should be reflected. We have a check in a test to verify this, per:
I also doubt that our change here resolved anything for the other issue. |
What type of PR is this?
/kind dependency-change
What this PR does / why we need it:
When building the go-capnp using Go 1.23 or Go tip, the following build error will be reported (an example build failure from the CRI-O project):
Thus, upgrade the go-capnp version to v3.0.1-alpha.2, which would fix the build issue on a newer version of Go.
Related:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?