Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor dependencies #2367

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind ci

What this PR does / why we need it:

This allows building the project offline.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Vendor dependencies to allow offline builds.

Copy link
Contributor

openshift-ci bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.51%. Comparing base (4e0f474) to head (99eebc8).
Report is 658 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2367      +/-   ##
==========================================
+ Coverage   37.53%   46.51%   +8.97%     
==========================================
  Files          15      121     +106     
  Lines        1268     4003    +2735     
  Branches      414      835     +421     
==========================================
+ Hits          476     1862    +1386     
- Misses        526     1638    +1112     
- Partials      266      503     +237     

This allows building the project offline.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@rphillips
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7f4052f into containers:main Aug 5, 2024
34 checks passed
@saschagrunert saschagrunert deleted the vendor branch August 5, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants