-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run waitpid on childs to ensure no zombies are left behind #2415
Conversation
fce9791
to
9e29d8a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2415 +/- ##
===========================================
+ Coverage 37.53% 63.26% +25.72%
===========================================
Files 15 121 +106
Lines 1268 4007 +2739
Branches 414 830 +416
===========================================
+ Hits 476 2535 +2059
- Misses 526 1472 +946
+ Partials 266 0 -266 |
Fixes containers/crun#1482 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
9e29d8a
to
9e944a7
Compare
Rebased |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
We can call waitpid on the process to reparent and ensure no zombies are left behind.
Which issue(s) this PR fixes:
Fixes containers/crun#1482
Fixes #2242
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?