Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run waitpid on childs to ensure no zombies are left behind #2415

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Sep 10, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

We can call waitpid on the process to reparent and ensure no zombies are left behind.

Which issue(s) this PR fixes:

Fixes containers/crun#1482
Fixes #2242

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Fixed issue that containers cannot be removed if init command was not found.

@saschagrunert saschagrunert force-pushed the child-wait branch 2 times, most recently from fce9791 to 9e29d8a Compare September 10, 2024 11:22
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.26%. Comparing base (4e0f474) to head (9e944a7).
Report is 724 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2415       +/-   ##
===========================================
+ Coverage   37.53%   63.26%   +25.72%     
===========================================
  Files          15      121      +106     
  Lines        1268     4007     +2739     
  Branches      414      830      +416     
===========================================
+ Hits          476     2535     +2059     
- Misses        526     1472      +946     
+ Partials      266        0      -266     

Fixes containers/crun#1482

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

Rebased

@kwilczynski
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 45a0edb into containers:main Sep 10, 2024
37 checks passed
@saschagrunert saschagrunert deleted the child-wait branch September 10, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants