Use fmt writer for systemd #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saschagrunert
force-pushed
the
systemd-write
branch
3 times, most recently
from
a3ba8aa
to
fbcb625
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #773 +/- ##
==========================================
- Coverage 31.44% 31.35% -0.09%
==========================================
Files 13 13
Lines 1129 1129
Branches 429 429
==========================================
- Hits 355 354 -1
+ Misses 493 492 -1
- Partials 281 283 +2 |
saschagrunert
force-pushed
the
systemd-write
branch
4 times, most recently
from
f82ce4d
to
ecdd517
Compare
|
@haircommander PTAL |
This uses a custom fmt writer for systemd output to preserve all information within the message field. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
systemd-write
branch
from
ecdd517
to
6e30fcf
Compare
|
/lgtm thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This uses a custom fmt writer for systemd output to preserve all information within the message field.
Which issue(s) this PR fixes:
Fixes #740
Special notes for your reviewer:
Alternative to #770 and #772
Does this PR introduce a user-facing change?