Add native types for server LogDriver and LogLevel
#777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This allows a better API usage by having native types around possible values. We also now rename the LogDriver for the container creation to `ContainerLogDriver` to be more distinct compared to the server log driver. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
changed the title
LogDriver and LogLevel
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
=======================================
Coverage 31.35% 31.35%
=======================================
Files 13 13
Lines 1129 1129
Branches 429 428 -1
=======================================
Hits 354 354
Misses 492 492
Partials 283 283 |
|
nice cleanup /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
What this PR does / why we need it:
This allows a better API usage by having native types around possible values. We also now rename the LogDriver for the container creation to
ContainerLogDriverto be more distinct compared to the server log driver.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?